Allow processing of a specific configuration file for the connection #479
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
donnerhacke
force-pushed
the
config-file
branch
from
852bfbc
to
dcc5784
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
donnerhacke
force-pushed
the
config-file
branch
2 times, most recently
from
5eb8b7d
to
dcc5784
Compare
|
Link to the patch on the other side: ansible-collections/ansible.netcommon#498 |
|
@donnerhacke it would be really helpful to have test for this. Currently, there's no coverage for the new lines, which is... suboptimal. |
Depending on the destination, libssh might need to be configured in a way, that the algorithms and methods need to be adjusted. Instead of adding each possible configuration option into the wrapper, including a config file (as it exists for ordinary OpenSSH) is much easier. This allows ansible to connect to devices with less well supported algorithms.
for more information, see https://pre-commit.ci
| file_name = kwargs['config_file'] | ||
| rc = libssh.ssh_options_parse_config(self._libssh_session, file_name.encode()) | ||
| if rc != libssh.SSH_OK or self._get_session_error_str() != "": | ||
| libssh.ssh_disconnect(self._libssh_session) |
There was a problem hiding this comment.
I think the disconnect here is not needed as we did not connect yet.
| @@ -243,6 +243,16 @@ cdef class Session(object): | |||
| if (key in OPTS_MAP or key in OPTS_DIR_MAP) and (kwargs[key] is not None): | |||
| self.set_ssh_options(key, kwargs[key]) | |||
|
|
|||
| if 'config_file' in kwargs: | |||
There was a problem hiding this comment.
This new key needs to be documented in the doc text above with the description of how the corner cases are handled.
The libssh itself reads the OpenSSH configuration files by default and the openssh configuration files have awkward precedence, so this documentation needs to clarify if this configuration file is parsed before the openssh ones, after them and if the same option is specified in both config and direct option, which one is effective.
@donnerhacke Please, let me know if you plan to get back to make this working or you abandoned this PR in favor of different solution (such as using the OpenSSH config directly).
SUMMARY
Depending on the destination, libssh might need to be configured in a way, that the algorithms and methods need to be adjusted. Instead of adding each possible configuration option into the wrapper, including a config file (as it exists for ordinary OpenSSH) is much easier. This allows ansible to connect to devices with less well supported algorithms.
This is a required step to fix connection issues with ansible.netcommon.libssh. The calling ansible.netcommon.libssh need to provide the new optional argument config_file. But this is a separate patch, which needs to be applied there.
ISSUE TYPE
ADDITIONAL INFORMATION