Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setting ansible_network_os optional for network_cli and netconf connections #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make setting ansible_network_os optional for network_cli and netconf connections #316

wants to merge 2 commits into from

Conversation

ganeshrn
Copy link
Member

@ganeshrn ganeshrn commented Aug 18, 2021 •
edited
Loading

SUMMARY

Make setting ansible_network_os optional

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

network_cli
netconf

ADDITIONAL INFORMATION

@ganeshrn ganeshrn mentioned this pull request Aug 18, 2021
Draft
@trishnaguha
Copy link
Member

@ganeshrn Is this a breaking change for httpapi?

Qalthos
Qalthos requested changes Aug 18, 2021
View reviewed changes
Copy link
Collaborator

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the name, but it's better than network_os, and I haven't had a better idea in all these years so 👍

plugins/connection/httpapi.py Outdated Show resolved Hide resolved
@ganeshrn
Copy link
Member Author

@trishnaguha It won't be a breaking change. The changes are backward compatible

@Qalthos Qalthos self-requested a review August 30, 2021 19:36
@justjais
Copy link
Member

@ganeshrn @Qalthos I am closing this PR as I've raised a duplicate PR #329 with the respective fix and fixing the sanity issues.

@justjais justjais closed this Sep 20, 2021
@ganeshrn ganeshrn reopened this Oct 20, 2021
@ganeshrn ganeshrn changed the title [DNM]Make setting ansible_network_os optional Make setting ansible_network_os optional for network_cli and netconf connections Oct 20, 2021
@ganeshrn
Make setting ansible_network_os optional for network_cli and netconf
2b04d0d 
*  Add `load_platform_plugins` method in network_cli and netconf
   connection to handle loading of sub-plugins when either invoked
   by setting `ansible_network_os` value of by calling it from
   the module code.
@ganeshrn
Copy link
Member Author

@ganeshrn @Qalthos I am closing this PR as I've raised a duplicate PR #329 with the respective fix and fixing the sanity issues.

Reopened the PR to handle network_cli and netconf connection plugins

@NilashishC NilashishC removed the request for review from Qalthos March 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qalthos Qalthos Qalthos requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@KB-perByte KB-perByte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ganeshrn @trishnaguha @justjais @Qalthos @KB-perByte