Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MASP inverse conversions #4193

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Dec 17, 2024

Describe your changes

Depends-on: #4146 (diff: https://github.com/anoma/namada/pull/4193/files/9f1d17825350c9d7ce9e0b2864a0ce74d9ac7c8c..43974e6d6e3b13c2e856199c493757e7dc963ce7)

Adds tests for the MASP inverse conversions.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 98.02555% with 17 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (be0e81f) to head (43974e6).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
crates/shielded_token/src/masp/shielded_wallet.rs 98.02% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
+ Coverage   74.48%   74.66%   +0.17%     
==========================================
  Files         341      341              
  Lines      107710   108469     +759     
==========================================
+ Hits        80227    80987     +760     
+ Misses      27483    27482       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco force-pushed the grarco/test-inverse-conversions branch from 5fca376 to e16fb8c Compare December 19, 2024 15:44
@grarco grarco marked this pull request as ready for review December 19, 2024 15:52
@grarco grarco requested a review from batconjurer December 19, 2024 16:41
@grarco grarco added the backport-libs-0.46 Backport libraries to 0.46 maintenance branch label Dec 23, 2024
@brentstone
Copy link
Collaborator

Should this be merged now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch MASP testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants