Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat/1098 - Fetch masp params in Namadillo #1124

Closed
wants to merge 2 commits into from

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Sep 18, 2024

Resolves #1098

To support building shielded Tx, we need to provide MASP params. This PR hooks up fetching and storing of params in Namadillo.

Notes

  • I move SessionKVStore into extension/src/extension as it uses the webextension-polyfill, meaning that package couldn't be used outside of the extension. Moving it here allows us to re-use IndexedDBKVStore in Namadillo
  • In 1114 I did some experimenting with fetching these params in a service worker, however, to do this the right way, I'll need to set up a better dev/build pipeline with rollup.js/vite so that we can use modules during development. For now, I will incorporate this in Namadillo, then follow-up with delegating this to a background worker

@jurevans jurevans self-assigned this Sep 18, 2024
@jurevans jurevans force-pushed the feat/1098-masp-params branch 2 times, most recently from 5940fbf to 4148409 Compare September 18, 2024 16:40
@jurevans
Copy link
Collaborator Author

Closing, this was implemented in another PR

@jurevans jurevans closed this Oct 21, 2024
@jurevans jurevans deleted the feat/1098-masp-params branch October 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK package: Hook up remaining Transfer types
1 participant