Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize single-argument unknown function invocations with known non-function target types #3270

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Optimize single-argument unknown function invocations with known non-function target types #3270

wants to merge 6 commits into from

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Jan 7, 2025 •
edited
Loading

@lukaszcz lukaszcz self-assigned this Jan 7, 2025
@lukaszcz lukaszcz added this to the 0.6.10 milestone Jan 7, 2025
@lukaszcz lukaszcz force-pushed the optimize-single-argument-unknown-functions branch 2 times, most recently from ba9afac to 8fe489c Compare January 7, 2025 18:01
@lukaszcz lukaszcz marked this pull request as ready for review January 8, 2025 10:04
@lukaszcz lukaszcz requested review from paulcadman and janmasrovira and removed request for paulcadman January 8, 2025 10:04
@janmasrovira janmasrovira force-pushed the optimize-single-argument-unknown-functions branch from 9fc5be0 to e9c71f4 Compare January 8, 2025 15:49
@lukaszcz lukaszcz force-pushed the optimize-single-argument-unknown-functions branch from e9c71f4 to 658c9e9 Compare January 10, 2025 09:02
janmasrovira
janmasrovira reviewed Jan 10, 2025
View reviewed changes
src/Juvix/Compiler/Tree/Transformation/Optimize/ConvertUnaryCalls.hs
@@ -0,0 +1,51 @@
module Juvix.Compiler.Tree.Transformation.Optimize.ConvertUnaryCalls where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a brief description of the optimization

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

test/Main.hs Outdated
"Juvix slow tests"
AllFinish
-- AllFinish
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably remove this line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, forgot about it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lukaszcz lukaszcz requested a review from janmasrovira January 10, 2025 15:30
@lukaszcz lukaszcz force-pushed the optimize-single-argument-unknown-functions branch from 2dc05ca to c28bbc3 Compare January 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcadman paulcadman Awaiting requested review from paulcadman

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

At least 1 approving review is required to merge this pull request.

Assignees

@lukaszcz lukaszcz

Labels
juvix-tree optimization
Projects
None yet
Milestone
0.6.10
Development

Successfully merging this pull request may close these issues.

Optimize single-argument unknown function invocations with known non-function target types
2 participants
@lukaszcz @janmasrovira