Use generic for object-map Record key type #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is it possible for object key to be a |
angus-c
requested changes
Feb 4, 2023
packages/object-map/index.d.ts
Outdated
| item: Record<string, T>, | ||
| callback: (key: string, value: T) => U | ||
| ): Record<string, U>; | ||
| declare function map<K extends string | number | symbol, T, U = T>( |
There was a problem hiding this comment.
I don't think object keys can ever be numbers
There was a problem hiding this comment.
hey! sorry for the late reply. you're right, that's my mistake. i updated the change to remove number from the type
This lets the function pass through more specific type information
sunnyzanchi
force-pushed
the
object-map-types
branch
from
b3fac98
to
9b54ed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the function pass through more specific type information
✔️ Updated tests and
yarn test-typespasses