Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EnergyEfficiency unit #1419

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add EnergyEfficiency unit #1419

wants to merge 9 commits into from

Conversation

Chef904
Copy link

@Chef904 Chef904 commented Aug 29, 2024

add unit for energy consumption from electric cars.

Wh/km

Common/.DS_Store Outdated Show resolved Hide resolved
@@ -0,0 +1,42 @@
{
"Name": "EnergyEfficiency",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What domain is this, is it related to transport?
If so, it feels a bit too domain specific for UnitsNet maybe.
Can you help me understand the domain and usecases better?

Here are some criteria we have to consider before adding new units:
https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#great--but-before-you-start-

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
it's like the FuelEfficiency Quantity but related to electric powered vehicles. This domain is getting more and more important these days.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it is getting kind of mainstream so maybe it makes sense to add something here.
However, maybe we just need to name it something else.

EnergyEfficiency means?

Googling energy efficiency units returns a lot of different things, from energy generators, heating/cooling, and more. Not much about EV efficiency in the first few results.

Rename EnergyEfficiency to...?

It seems there is no well defined name for this, but electric vehicle converters do pop up for these units.

"Electric car energy economy"
https://www.aqua-calc.com/one-to-all/electric-car-energy-economy

"Electric Vehicle Range / Efficiency Unit Conversions"
https://home.hasslers.net/ev/convert/

I propose ElectricVehicleEfficiency, since there does not seem to be a well defined, generic physical quantity with units like kWH/km. They are all domain specific; heating/cooling, energy generators, etc.

Maybe also add kWh/100km unit?

Most common in Europe is the specification kilowatt-hours per 100 kilometers (kWh/100km).
https://e-automobile.info/en/calculator.php

Summary of proposed changes to PR

  • Rename quantity to ElectricVehicleEfficiency
  • Add unit WattHourPer100Kilometer with prefix Kilo

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see below comments.

@@ -0,0 +1,42 @@
{
"Name": "EnergyEfficiency",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it is getting kind of mainstream so maybe it makes sense to add something here.
However, maybe we just need to name it something else.

EnergyEfficiency means?

Googling energy efficiency units returns a lot of different things, from energy generators, heating/cooling, and more. Not much about EV efficiency in the first few results.

Rename EnergyEfficiency to...?

It seems there is no well defined name for this, but electric vehicle converters do pop up for these units.

"Electric car energy economy"
https://www.aqua-calc.com/one-to-all/electric-car-energy-economy

"Electric Vehicle Range / Efficiency Unit Conversions"
https://home.hasslers.net/ev/convert/

I propose ElectricVehicleEfficiency, since there does not seem to be a well defined, generic physical quantity with units like kWH/km. They are all domain specific; heating/cooling, energy generators, etc.

Maybe also add kWh/100km unit?

Most common in Europe is the specification kilowatt-hours per 100 kilometers (kWh/100km).
https://e-automobile.info/en/calculator.php

Summary of proposed changes to PR

  • Rename quantity to ElectricVehicleEfficiency
  • Add unit WattHourPer100Kilometer with prefix Kilo

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants