Commits on Feb 14, 2024

1. 💥🐛Change DataMember ordering to 1-indexed (#1360) …

   Related #1200
   Fixes #1356
   
   Apparently, protobuf-net does not support 0-indexed order values.
   
   - Change `DataMember` explicit order from 0-indexed to 1-indexed
   
   Some investigation indicates that the actual order value is not important, only the relative ordering:
   #1356 (comment)
   
   - WCF should tolerate this, according to its docs. #1356 (comment)
   - Binary formatters hopefully only care about relative ordering and thus still compatible?
   	- Protobuf-net, it never worked and should be OK
   	- [BinaryFormatter](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.serialization.formatters.binary.binaryformatter?view=net-8.0) is obsolete and generally not recommended for years, so hopefully no users are affected
   	- A bunch of others exist too, haven't looked into how they handle this
   - XML/JSON serializers should tolerate any order, can't imagine it breaking these?

   

   angularsen committed Feb 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 750df85
   • Browse repository at this point

   Copy the full SHA

   750df85 View commit details

   Browse the repository at this point in the history