Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: Celcius -> Celsius #1347

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix typo: Celcius -> Celsius #1347

merged 1 commit into from
Jan 2, 2024

Conversation

Muximize
Copy link
Contributor

@Muximize Muximize commented Jan 2, 2024

Came across this while working on #1329. I'm afraid it's an API-breaking change, so maybe it should wait for v6?

@angularsen
Copy link
Owner

angularsen commented Jan 2, 2024 •
edited
Loading

Nice catch.
Yes, this would be a breaking change on FromXXX factory methods among other things. Let's target v6 branch and merge it there. We don't have a good way of marking only the plural form as obsolete though, so people will only be able to migrate when upgrading.

@Muximize Muximize changed the base branch from master to release/v6 January 2, 2024 12:17
@Muximize
Copy link
Contributor Author

Muximize commented Jan 2, 2024

Sounds like a plan! I rebased this and targeted v6.

@angularsen angularsen merged commit cff63a6 into angularsen:release/v6 Jan 2, 2024
1 check passed
@angularsen
Copy link
Owner

Related:
#1200

@angularsen angularsen mentioned this pull request Jan 2, 2024
Open
13 tasks
@Muximize Muximize deleted the fix-celcius-celsius branch January 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muximize @angularsen