-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XP One nuget per quantity #1181
Draft
angularsen
wants to merge
2
commits into
master
Choose a base branch
from
agl/split-nuget-v5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEMP Remove all but 7 SI quantities Add Duration and Length projects TEMP Remove non-SI unit definitions Add UnitsNet.SI, move SI stuff there Include the 8 quantity projects in solution
Closed
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
angularsen
added
the
pinned
Issues that should not be auto-closed due to inactivity.
label
Jul 14, 2023
test comment |
test 2 |
test 3 |
angularsen
added
pending-response
Waiting for response from author of PR/issue.
and removed
wait-for-author
labels
Jul 16, 2023
test 4 |
test 5 |
github-actions
bot
removed
the
pending-response
Waiting for response from author of PR/issue.
label
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #372, #1180
Experiment with splitting up UnitsNet nuget into:
This is already done for UnitsNet.nanoFramework nugets:
https://www.nuget.org/packages?q=unitsnet.nanoframework
We might also provide meta nuget packages that bring in multiple nugets in a single package:
Benefits
UnitsNet.dll
is ~2MB as of 2023-01-07.Problems
QuantityType
enum must be replaced by strings and usingQuantityInfo
insteadUnitSystem
andBaseUnits
rely on the 7 SI quantities Length, Mass, etc.Speed = Length / Duration
andMass.FromGravitationalForce(Force f)
. We might be able to provide this with meta nuget packages that bring in the most common quantities and arithmetic/conversions between them.Design proposal
QuantityInfo
to fully describe a quantity, instead of relying on generated code for known quantities spread over various types.UnitAbbreviationsCache.LoadGeneratedAbbreviations()
based on generated code.Acceleration.RegisterDefaultConversions
and similar for other quantities.