Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/tree): implement typeahead label #29055

Merged

Conversation

BobobUnicorn
Copy link
Collaborator

Implement typeahead labels for Tree. Follow the established pattern that Menu and List use.

  • implement CdkTreeNode#cdkTreeNodeTypeaheadLabel
  • implement CdkTreeNode#getLabel

Copy of #28251

Implement typeahead labels for Tree. Follow the established pattern that
Menu and List use.
 - implement CdkTreeNode#cdkTreeNodeTypeaheadLabel
 - implement CdkTreeNode#getLabel
@BobobUnicorn BobobUnicorn marked this pull request as ready for review May 15, 2024 22:03
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 15, 2024
@crisbeto crisbeto added target: rc This PR is targeted for the next release-candidate and removed target: rc This PR is targeted for the next release-candidate labels May 16, 2024
@crisbeto
Copy link
Member

Merging this directly since it's not targeting the main branch.

@crisbeto crisbeto merged commit 5d001ec into angular:cdk-tree-revamp May 16, 2024
44 of 47 checks passed
@BobobUnicorn BobobUnicorn deleted the cdk-tree-revamp-typeahead-label branch May 16, 2024 18:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants