Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Added Persian (fa) Locale #751

Closed
wants to merge 4 commits into from

Conversation

ehsanr-r
Copy link

I added a new strings.xml file to support the Persian language.

@Arrowsome
Copy link

There are multiple other pull request like this, you could've checked theme before making a pull request. #739 #642.

@arriolac
Copy link
Contributor

arriolac commented Dec 20, 2023

Thanks for the contribution! There are a couple more strings missing:

  • a11y_plant_item_image
  • a11y_back
    Once updated, we can go ahead and merge this in.

@ehsanr-r ehsanr-r requested a review from a team as a code owner December 22, 2023 19:19
@arriolac arriolac requested review from arriolac and removed request for riggaroo December 26, 2023 17:35
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please sign CLA and will merge in. Thanks!

@arriolac
Copy link
Contributor

CLA still failing (see https://github.com/android/sunflower/pull/751/checks?check_run_id=19988830749). Alternatively, you can open a new PR with a commit signed by an email address you used to sign the CLA.

@riggaroo
Copy link
Collaborator

riggaroo commented Aug 2, 2024

Hi,
Thanks for your contribution, however Sunflower is going to be archived in favour of maintaining a smaller set of up-to-date set of compose-samples, that can be found here: https://github.com/android/compose-samples, as well as snippets that can be found here: https://github.com/android/snippets.

Please feel free to keep your fork up-to-date for your learning, but this repository will be archived shortly.

@riggaroo riggaroo closed this Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants