Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Add translation for Vietnamese #733

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Add translation for Vietnamese #733

merged 4 commits into from
Dec 27, 2023

Conversation

hieuwu
Copy link
Contributor

@hieuwu hieuwu commented Jul 31, 2021 •
edited
Loading

Add translation for Vietnamese language.
Screenshots for reference:
sunflower-3
sunflower-4
sunflower-5
sunflower-1
sunflower-2

@hiepcute
Copy link

Just come across this Pull Request then try to check the words. Everything is well done in Vietnamese. Good job @hieuwu

@hieuwu
Copy link
Contributor Author

hieuwu commented Aug 22, 2021

Just come across this Pull Request then try to check the words. Everything is well done in Vietnamese. Good job @hieuwu

Thank you for your review

@minhhien21
Copy link

As a native Vietnamese, I see this translation is good. Well done bro

@hieuwu
Copy link
Contributor Author

hieuwu commented Aug 22, 2021

As a native Vietnamese, I see this translation is good. Well done bro

Thanks

@arriolac
Copy link
Contributor

Thanks for your contribution! The translation for a11y_back is missing - please add and I'll go ahead and merge this PR.

@hieuwu hieuwu requested a review from a team as a code owner December 27, 2023 02:07
@hieuwu hieuwu requested a review from arriolac December 27, 2023 02:07
@hieuwu
Copy link
Contributor Author

hieuwu commented Dec 27, 2023 •
edited
Loading

Thanks for your contribution! The translation for a11y_back is missing - please add and I'll go ahead and merge this PR.

Thank you for your review. I have just updated. Please take a look. I have a question, in the string.xml this string a11y_back is specified as not translatable (translatable = false). Do we need to add it into other language?

arriolac
arriolac approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arriolac arriolac merged commit 5f864ae into android:main Dec 27, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arriolac arriolac arriolac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hieuwu @hiepcute @minhhien21 @arriolac