Fix issue #2 #3
Open
Fix issue #2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iewModel was set as a wrong value
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Why isn't this issue merged to master then? |
19diwakar
approved these changes
Nov 7, 2019
…profileobservalblefieldsviewmodel-state-fix � Conflicts: � BasicSample/app/src/main/java/com/example/android/databinding/basicsample/data/ProfileObservableViewModel.kt
|
@diwakarsinghdiwakar this branch is updated and the conflicts are resolved. I believe this is now ready to be merged. |
|
@codingjeremy should we close it or there is still chances to get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JoseAlcerreca I actually don't know how to approach this, I didn't contribute before so much. This fix the problem stated at issue #2 . Let me know if further modification needed.
I think some refactoring could be done on ViewModels to move out the duplicate parts.Refactored a little bit as popularity decision logic based on like count is common on bothProfileObservableViewModelandProfileObservableFieldsViewModel.