Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories display option, small improvements #10

Closed

Conversation

my-curiosity
Copy link
Contributor

@my-curiosity my-curiosity commented Jan 19, 2024

Hello @andreasschenkel ,

following #9, this PR adds new functionality that we found useful:

  1. A top level category can be shown for the courses in table
  • this is disabled by default, configurable and can be used with/ instead of/ without duration time ranges depending on users' preference
  • moodle/category:viewhiddencategories permission is respected: category names are only displayed when they are visible or when the user is allowed to see them in course context, otherwise get_string('categoryhidden') is returned
  1. Set background color of non-standard roles to #eee (equal to guest color) instead of white for better contrast
  • the solution is not very clean and uses CSS wildcards, so we could modify or remove this part as needed
  1. Added : between role name and amount of courses for readability, for example "Manager : 1 Course"

  2. Simplified some expressions in code

  3. Set required Moodle version to 4.0

Let me know if any additional changes are needed, for example if you plan to merge the develop branch and it causes conflicts.

@andreasschenkel
Copy link
Owner

Thank you for your new feature pull request. Please have a look at the develop branch. I merged your code to the develop branch and did some changes (see commit messages).
Does the develop branch still supports your needs?

@my-curiosity
Copy link
Contributor Author

Changes in the develop branch are very helpful, thank you for improving the code. Closing this PR as all the requested features are already merged there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants