Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] issue262 fixing SQL-Hint deleting when clearing script from comments #792

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

skryzh
Copy link
Contributor

@skryzh skryzh commented Oct 18, 2024

#Fixing SQL-Hint deleting when clearing script from comments
#262

What is done:

  1. Added checking token type for Token.Comment.Multiline.Hint and Token.Comment.Single.Hint
  2. Added some tests for covering basic behavior
  3. Checked w/ tests from project
  4. Checked on production SQL scripts
  5. Checked as part of Airflow engine, because this library is used for splitting SQL statements before execute. And seems like this helped and Hints are working now.

Before submitting your pull request please have a look at the
following checklist:

  • ran the tests (pytest)
  • all style issues addressed (flake8)
  • your changes are covered by tests
  • your changes are documented, if needed

In addition, please take care to provide a proper description
on what your change does, fixes or achieves when submitting the
pull request.

@skryzh
Copy link
Contributor Author

skryzh commented Oct 18, 2024

Hi, @andialbrecht!
Please consider to review this pr, for our project it is a vital to use SQL-Hints to help Vertica increase performance w/ complex scripts

Copy link
Owner

@andialbrecht andialbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skryzh hey, thanks for the pull request! Looks good so far, I've got just some nitpicks.

.gitignore Outdated Show resolved Hide resolved
tests/test_format.py Outdated Show resolved Hide resolved
tests/test_format.py Outdated Show resolved Hide resolved
Copy link
Owner

@andialbrecht andialbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks and sorry for the delay.... busy times, as usual :-D

@andialbrecht andialbrecht merged commit 48bd14e into andialbrecht:master Nov 14, 2024
10 checks passed
@skryzh
Copy link
Contributor Author

skryzh commented Nov 14, 2024

It's ok, same :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants