Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update links in issue template #312

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: Update links in issue template #312

merged 1 commit into from
Oct 21, 2024

Conversation

popey
Copy link
Contributor

@popey popey commented Oct 21, 2024

Update links from slack to discourse.

@popey
chore: Update links in issue template
a3d3664 
Update links from slack to discourse.

Signed-off-by: Alan Pope <[email protected]>
@github-actions GitHub Actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
make .tool/task
make[1]: Entering directory '/home/runner/work/stereoscope/stereoscope'
make[1]: Leaving directory '/home/runner/work/stereoscope/stereoscope'
.tool/task show-benchstat
?   	github.com/anchore/stereoscope	[no test files]
?   	github.com/anchore/stereoscope/examples	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal	0.004s
?   	github.com/anchore/stereoscope/internal/bus	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal/containerd	0.007s
PASS
ok  	github.com/anchore/stereoscope/internal/docker	0.004s
?   	github.com/anchore/stereoscope/internal/log	[no test files]
PASS
ok  	github.com/anchore/stereoscope/internal/podman	0.005s
?   	github.com/anchore/stereoscope/pkg/event	[no test files]
?   	github.com/anchore/stereoscope/pkg/event/parsers	[no test files]
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkTarIndex-4   	   33415	     35840 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33442	     35943 ns/op	    5698 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33506	     36127 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33020	     36309 ns/op	    5701 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   32954	     35934 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33030	     36007 ns/op	    5699 B/op	      93 allocs/op
BenchmarkTarIndex-4   	   33306	     36687 ns/op	    5699 B/op	      93 allocs/op
PASS
ok  	github.com/anchore/stereoscope/pkg/file	10.977s
PASS
ok  	github.com/anchore/stereoscope/pkg/filetree	0.005s
?   	github.com/anchore/stereoscope/pkg/filetree/filenode	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/image	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/containerd	0.007s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/docker	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/oci	0.005s
PASS
ok  	github.com/anchore/stereoscope/pkg/image/oci/credhelpers	0.005s
?   	github.com/anchore/stereoscope/pkg/image/podman	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/image/sif	0.004s
?   	github.com/anchore/stereoscope/pkg/imagetest	[no test files]
PASS
ok  	github.com/anchore/stereoscope/pkg/tree	0.003s
PASS
ok  	github.com/anchore/stereoscope/pkg/tree/node	0.004s
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/test/integration
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1098	   1082765 ns/op	  272014 B/op	    2248 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1107	   1078480 ns/op	  271538 B/op	    2247 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1107	   1082821 ns/op	  271461 B/op	    2247 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1098	   1160616 ns/op	  271533 B/op	    2246 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1106	   1103044 ns/op	  271259 B/op	    2246 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1083	   1141704 ns/op	  271301 B/op	    2246 allocs/op
BenchmarkSimpleImage_GetImage/docker-archive-4 	    1100	   1126751 ns/op	  271104 B/op	    2246 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      60	  18855935 ns/op	  401746 B/op	    2701 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      62	  19191098 ns/op	  401565 B/op	    2700 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      62	  19147711 ns/op	  400608 B/op	    2700 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      58	  20844294 ns/op	  400869 B/op	    2700 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      58	  19567777 ns/op	  400759 B/op	    2700 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      60	  19542982 ns/op	  400872 B/op	    2699 allocs/op
BenchmarkSimpleImage_GetImage/podman-4         	      62	  19608054 ns/op	  400464 B/op	    2697 allocs/op
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 345B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load build context
#3 transferring context: 209B done
#3 DONE 0.0s

#4 [1/3] ADD file-1.txt /somefile-1.txt
#4 CACHED

#5 [2/3] ADD file-2.txt /somefile-2.txt
#5 CACHED

#6 [3/3] ADD target /
#6 CACHED

#7 exporting to image
#7 exporting layers done
#7 writing image sha256:dcf338dbbfd506d06df45582887fc9dce6c575460857b9c2761fd4a17a6b8a5e done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:latest done
#7 DONE 0.0s
ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
--- FAIL: BenchmarkSimpleImage_GetImage
    image_fixtures.go:193: using existing image tar: 'test-fixtures/cache/stereoscope-fixture-image-simple-04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7.tar' (size: 22528, modified: 2024-10-21 13:38:08.061784583 +0000 UTC, mode: -rw-r--r--)
    image_fixtures.go:241: Build docker image: name="stereoscope-fixture-image-simple" tag="04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7"
    image_fixtures.go:291: saveImage running: docker image save stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7
    image_fixtures.go:286: 
        	Error Trace:	/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:286
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:162
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:152
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:33
        	            				/home/runner/work/stereoscope/stereoscope/test/integration/fixture_image_simple_test.go:163
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	BenchmarkSimpleImage_GetImage
        	Messages:   	could not import docker image to containerd (shell out)
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53248	     22325 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53382	     22446 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53326	     22514 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53188	     22292 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53413	     22406 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   53168	     22376 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/docker-archive-4         	   52982	     22492 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53077	     22480 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53642	     22330 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53959	     22329 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53316	     22370 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53505	     22364 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53019	     22336 ns/op	    2712 B/op	      21 allocs/op
BenchmarkSimpleImage_FetchSquashedContents/podman-4                 	   53556	     22332 ns/op	    2712 B/op	      21 allocs/op
#0 building with "default" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 345B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load build context
#3 transferring context: 209B done
#3 DONE 0.0s

#4 [1/3] ADD file-1.txt /somefile-1.txt
#4 CACHED

#5 [2/3] ADD file-2.txt /somefile-2.txt
#5 CACHED

#6 [3/3] ADD target /
#6 CACHED

#7 exporting to image
#7 exporting layers done
#7 writing image sha256:dcf338dbbfd506d06df45582887fc9dce6c575460857b9c2761fd4a17a6b8a5e done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7 done
#7 naming to docker.io/library/stereoscope-fixture-image-simple:latest done
#7 DONE 0.0s
ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
--- FAIL: BenchmarkSimpleImage_FetchSquashedContents
    image_fixtures.go:193: using existing image tar: 'test-fixtures/cache/stereoscope-fixture-image-simple-04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7.tar' (size: 22528, modified: 2024-10-21 13:38:08.061784583 +0000 UTC, mode: -rw-r--r--)
    image_fixtures.go:241: Build docker image: name="stereoscope-fixture-image-simple" tag="04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7"
    image_fixtures.go:291: saveImage running: docker image save stereoscope-fixture-image-simple:04e16e44161c8888a1a963720fd0443cbf7eef8101434c431de8725cd98cc9f7
    image_fixtures.go:286: 
        	Error Trace:	/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:286
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:162
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:152
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:33
        	            				/home/runner/work/stereoscope/stereoscope/pkg/imagetest/image_fixtures.go:64
        	            				/home/runner/work/stereoscope/stereoscope/test/integration/fixture_image_simple_test.go:189
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	BenchmarkSimpleImage_FetchSquashedContents
        	Messages:   	could not import docker image to containerd (shell out)
FAIL
exit status 1
FAIL	github.com/anchore/stereoscope/test/integration	40.001s
?   	github.com/anchore/stereoscope/test/integration/test-fixtures/registry	[no test files]
FAIL
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
ctr: 
           │ .tmp/benchmark-c7eebfb.txt │
           │           sec/op           │
TarIndex-4                  36.01µ ± 2%

           │ .tmp/benchmark-c7eebfb.txt │
           │            B/op            │
TarIndex-4                 5.565Ki ± 0%

           │ .tmp/benchmark-c7eebfb.txt │
           │         allocs/op          │
TarIndex-4                   93.00 ± 0%

pkg: github.com/anchore/stereoscope/test/integration
                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │           sec/op           │
SimpleImage_GetImage/docker-archive-4                  1.103m ± 5%
SimpleImage_GetImage/podman-4                          19.54m ± 7%
geomean                                                4.643m

                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │            B/op            │
SimpleImage_GetImage/docker-archive-4                 265.1Ki ± 0%
SimpleImage_GetImage/podman-4                         391.5Ki ± 0%
geomean                                               322.1Ki

                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │         allocs/op          │
SimpleImage_GetImage/docker-archive-4                  2.246k ± 0%
SimpleImage_GetImage/podman-4                          2.700k ± 0%
geomean                                                2.463k

ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │           sec/op           │
SimpleImage_FetchSquashedContents/docker-archive-4                  22.41µ ± 1%
SimpleImage_FetchSquashedContents/podman-4                          22.34µ ± 1%
geomean                                                             22.37µ

                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │            B/op            │
SimpleImage_FetchSquashedContents/docker-archive-4                 2.648Ki ± 0%
SimpleImage_FetchSquashedContents/podman-4                         2.648Ki ± 0%
geomean                                                            2.648Ki

                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │         allocs/op          │
SimpleImage_FetchSquashedContents/docker-archive-4                   21.00 ± 0%
SimpleImage_FetchSquashedContents/podman-4                           21.00 ± 0%
geomean                                                              21.00
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: AMD EPYC 7763 64-Core Processor                
ctr: 
           │ .tmp/benchmark-c7eebfb.txt │
           │           sec/op           │
TarIndex-4                  36.01µ ± 2%

           │ .tmp/benchmark-c7eebfb.txt │
           │            B/op            │
TarIndex-4                 5.565Ki ± 0%

           │ .tmp/benchmark-c7eebfb.txt │
           │         allocs/op          │
TarIndex-4                   93.00 ± 0%

pkg: github.com/anchore/stereoscope/test/integration
                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │           sec/op           │
SimpleImage_GetImage/docker-archive-4                  1.103m ± 5%
SimpleImage_GetImage/podman-4                          19.54m ± 7%
geomean                                                4.643m

                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │            B/op            │
SimpleImage_GetImage/docker-archive-4                 265.1Ki ± 0%
SimpleImage_GetImage/podman-4                         391.5Ki ± 0%
geomean                                               322.1Ki

                                      │ .tmp/benchmark-c7eebfb.txt │
                                      │         allocs/op          │
SimpleImage_GetImage/docker-archive-4                  2.246k ± 0%
SimpleImage_GetImage/podman-4                          2.700k ± 0%
geomean                                                2.463k

ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │           sec/op           │
SimpleImage_FetchSquashedContents/docker-archive-4                  22.41µ ± 1%
SimpleImage_FetchSquashedContents/podman-4                          22.34µ ± 1%
geomean                                                             22.37µ

                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │            B/op            │
SimpleImage_FetchSquashedContents/docker-archive-4                 2.648Ki ± 0%
SimpleImage_FetchSquashedContents/podman-4                         2.648Ki ± 0%
geomean                                                            2.648Ki

                                                   │ .tmp/benchmark-c7eebfb.txt │
                                                   │         allocs/op          │
SimpleImage_FetchSquashedContents/docker-archive-4                   21.00 ± 0%
SimpleImage_FetchSquashedContents/podman-4                           21.00 ± 0%
geomean                                                              21.00

@wagoodman wagoodman added the changelog-ignore Don't include this issue in the release changelog label Oct 21, 2024
@wagoodman wagoodman merged commit 6db3c17 into main Oct 21, 2024
7 checks passed
@wagoodman wagoodman deleted the slack-to-discourse branch October 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
changelog-ignore Don't include this issue in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popey @wagoodman