fix directory leak leading to out of disk

[ghost]

Issue 132

Why

When using stereoscope as a library, for long running processes, the relationship between the providers may cause files in temp to not get cleaned up after image.Image.Cleanup is called.

What

• enable image.Image.Cleanup to own tmpDirGenerator and perform cleanup any directories related to the image.

How Tested

• per guide

make bootstrap
make unit
make integration

• using the basic example

$ docker pull ruby:2.6-alpine3.11
$ ls -l /tmp/ | grep stereo
$ go run basic.go docker:ruby:2.6-alpine3.11 &>/dev/null
$ ls -l /tmp/ | grep stereo

[kzantow]

Are you able to sign-off your commits? https://github.com/anchore/stereoscope/blob/main/CONTRIBUTING.md#sign-off-your-work

[ghost]

@kzantow
I thought I did this (dc6bd53) - I guess I am not sure what I am missing. Can you provide me guidance of what I am missing?

[kzantow]

@slimdevl I'm not entirely sure why DCO isn't passing, it looks right. Did you use git commit -s / git commit --signoff? Maybe try the steps listed here?: https://github.com/anchore/stereoscope/pull/161/checks?check_run_id=11626027320

[ghost]

'm not entirely sure why DCO isn't passing, it looks right. Did you use

I manually added those fields as recommended by the guide. Let me see if I can get the -s (maybe there is something I need to figure out there)

[ghost]

@slimdevl I'm not entirely sure why DCO isn't passing, it looks right. Did you use git commit -s / git commit --signoff? Maybe try the steps listed here?: https://github.com/anchore/stereoscope/pull/161/checks?check_run_id=11626027320

This worked like magic, thanks @kzantow !

[wagoodman]

Great find! I think promoting the temp dir generator to the image makes sense. I've pushed a few of adjustments:

• update the comment for the package Cleanup() function to clearly indicate that this is deprecated
• restore the root temp directory generator (to facilitate the package Cleanup function)
• Added both removal of the contentCacheDir and cleanup of the tmp directory generator in the Image object. This way someone constructing their own image object could in theory provider a temp dir generator that did not create the contentCacheDir and everything would still work.