Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add horizontalPodAutoscaler definitions for all deployments #153

Closed
wants to merge 3 commits into from

Conversation

sschne
Copy link

@sschne sschne commented Jul 20, 2021

Add horizontalPodAutoscaler definitions for all deployments dynamically adjust to the workload.

@sschne
Copy link
Author

sschne commented Jul 22, 2021

fixes #90

@zhill
Copy link
Member

zhill commented Jul 27, 2021

Thanks @sschne we'll take a look

@Btodhunter
Copy link
Member

@sschne thanks for the PR, this will be a great addition to the chart! I have a couple requests before we can merge.

  • The chart version needs to be bumped to pass CI & allow the chart to be released
  • The analyzer pods should not scale based on CPU utilization, in an ideal deployment your CPU will be around 100% on the analyzer at all times. The image queue depth would be a good metric for this, but that isn't available to all Anchore deployments out of the box. For now, maybe we should just remove the analyzer scaling config.

I'm working on testing this implementation and will approve ASAP.

@sschne sschne force-pushed the feature/anchore-engine-hpa branch 2 times, most recently from 79c71ec to f7e3cfa Compare September 16, 2021 12:47
@sschne
Copy link
Author

sschne commented Mar 29, 2022

Any chance to get this reviewed?

sschne and others added 3 commits December 21, 2022 17:54
Signed-off-by: Brady Todhunter <[email protected]>
@Btodhunter Btodhunter changed the base branch from master to main December 22, 2022 01:59
HN23 added a commit that referenced this pull request Oct 24, 2023
* admission controller ci installs anchore engine to have endpoint
* update test and ci/fake-values for adm. cont
* update anchoreEndpoint with protocol

Signed-off-by: Hung Nguyen <[email protected]>

---------

Signed-off-by: Hung Nguyen <[email protected]>
@zhill
Copy link
Member

zhill commented Oct 31, 2024

I'm going to close this as stale given the chart in question is EOL'd anyway. Please let us know if we should re-orient this at the Enterprise chart instead.

@zhill zhill closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants