Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/projects: Add documentation for Stingray project #1489

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PopPaul2021
Copy link
Contributor

PR Description

This commit adds the documentation for the ad9081_fmca_ebz_x_band project.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor concerns, a patch to address the comments.
See patch message.
Apply what you find coherent.

0001-Review-Add-documentation-for-Stingray-project.patch

Thanks

docs/projects/ad9081_fmca_ebz_x_band/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9081_fmca_ebz_x_band/index.rst Outdated Show resolved Hide resolved
docs/projects/ad9081_fmca_ebz_x_band/index.rst Outdated Show resolved Hide resolved
@PopPaul2021
Copy link
Contributor Author

V2: I've added the patch, thanks for the review.

PopPaul2021 and others added 2 commits October 23, 2024 11:22
This commit adds the documentation for the ad9081_fmca_ebz_x_band
project.

Signed-off-by: PopPaul2021 <[email protected]>
Change link to axi_tdd.
Order cpu addresses table and change axi_iic_pmod, axi_spipmod and
axi_spi_fmc address.
Add I2C connection cpu address, clarify cpu address and device address.
Update README.md link.

Signed-off-by: Jorge Marques <[email protected]>
@PopPaul2021
Copy link
Contributor Author

V3: After rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants