fix lint

amundsen-io · Apr 11, 2020 · 8fb6b43 · 8fb6b43
1 parent ffa1c55
commit 8fb6b43
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/search_service/api/dashboard.py b/search_service/api/dashboard.py
@@ -3,15 +3,14 @@
 
 from flask_restful import fields, Resource, marshal_with, reqparse  # noqa: I201
 from flasgger import swag_from
-from amundsen_common.models.dashboard import DashboardSummary, DashboardSummarySchema
 
 from search_service.proxy import get_proxy_client
 
 
 DASHBOARD_INDEX = 'dashboard_search_index'
 
 
-# Use common
+# todo: Use common to produce this
 dashboard_fields = {
     "uri": fields.String,
     "cluster": fields.String,
@@ -26,7 +25,7 @@
 
 search_dashboard_results = {
     "total_results": fields.Integer,
-    "results": fields.Nested(DashboardSummary, default=[])
+    "results": fields.Nested(dashboard_fields, default=[])
 }
 
 
@@ -46,6 +45,7 @@ def __init__(self) -> None:
 
         super(SearchDashboardAPI, self).__init__()
 
+    @marshal_with(search_dashboard_results)
     @swag_from('swagger_doc/dashboard/search_dashboard.yml')
     def get(self) -> Iterable[Any]:
         """

diff --git a/search_service/models/dashboard.py b/search_service/models/dashboard.py
@@ -1,7 +1,6 @@
-from typing import List, Set
+from typing import Set
 
 import attr
-from marshmallow_annotations.ext.attrs import AttrsSchema
 from amundsen_common.models.dashboard import DashboardSummary, DashboardSummarySchema
 
 from search_service.models.base import Base