Snapshot release v5 #481
Merged
Snapshot release v5 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds validator support for the two new `<link rel=preload>` attributes, and adds srcset URL rewriting for imagesrcset. Fixes ampproject/amphtml#29302 PiperOrigin-RevId: 325359140
…ackager request.proto was missing ACTIONS. ACTIONS is now deprecated so adding in comment that 5 is reserved. github.com/ampproject/amppackager/transformer/request/request.proto github.com/ampproject/amphtml/validator/validator.proto PiperOrigin-RevId: 326555470
The inline style attribute is one of the first things checked for URLs. And we unfortunately skipped all the rest of the URL rewriting when there is one. This also exposed a bug with rewriting an image with `src=#`. We would generate a new srcset for the image, but the validator will not accept `# 123w` as a valid source in the srcset. Now, we just skip such srcs. PiperOrigin-RevId: 326745297
We will now transform (with `data-hero` and size-inferred hero images): - `<amp-img>` with src/srcset - `<amp-video>` with `[poster]` or `<amp-img placeholder>` child - `<amp-video-iframe>` with `[poster]` or `<amp-img placeholder>` child - `<amp-iframe>` with `<amp-img placeholder>` child Additionally, it leaves a few TODOs for better support: - Support pixel density srcsets - Support arbitrary `<link rel=preload>` Fixes ampproject/amphtml#28954 Re: #461 PiperOrigin-RevId: 327496988
Match the changes in ampproject/amphtml#30252 PiperOrigin-RevId: 334206765
…n x was missing. PiperOrigin-RevId: 334982571
97% (and growing) of Chrome browsers that support SXG also support loading=lazy. We still prioritize (via preload and loading=eager img) hero images. Requires transforming with Version 5. Re: #465 PiperOrigin-RevId: 336760832
Also updates the `<link>` generation to use `imagesrcset` and `imagesizes`, which are both supported in Chrome 73+. We don't need to do anything fancy! Re: #461 PiperOrigin-RevId: 337974534
Running `go test ./...` causes these changes.
https://html.spec.whatwg.org/multipage/images.html#parsing-a-srcset-attribute. Addresses #461. PiperOrigin-RevId: 338555233
PiperOrigin-RevId: 338732974
|
|
|
/cc @Gregable @MichaelRybak @ddlfg @honeybadgerdontcare Please (re-)sign the CLA. Thanks! |
|
done |
banaag
reviewed
Oct 24, 2020
|
release signed |
Gregable
approved these changes
Oct 26, 2020
banaag
approved these changes
Oct 26, 2020
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.