Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskip carousel test thats passing #40228

Merged
merged 2 commits into from
Jan 14, 2025
Merged

unskip carousel test thats passing #40228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8d413
unskip carousel e2e tests
erwinmombay Jan 13, 2025
754082a
remove failing tests on CI
erwinmombay Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ describes.endtoend(
await expect(slidesRects[0].width).to.equal(pageWidth);
});

// TODO(#24195): fix this flaky test.
it.skip('should layout the two adjacent slides', async function () {
it('should layout the two adjacent slides', async function () {
const [firstSlideRect, secondSlideRect, lastSlideRect] = [
await controller.getElementRect(await getSlide(controller, 0)),
await controller.getElementRect(await getSlide(controller, 1)),
Expand Down
Loading