Skip to content

Commit

Permalink
unskip carousel e2e tests
Browse files Browse the repository at this point in the history
  • Loading branch information
erwinmombay committed Jan 13, 2025
1 parent 46da0e5 commit be8d413
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,18 @@ describes.endtoend(
nextArrow = await getNextArrow(controller);
});

// TODO(#40214): fix flaky test.
it.skip('should have the arrows in the correct initial state', async () => {
it('should have the arrows in the correct initial state', async () => {
await expect(css(prevArrow, 'opacity')).to.equal('0');
await expect(css(nextArrow, 'opacity')).to.equal('1');
});

// TODO(#40214): fix flaky test.
it.skip('should show the prev arrow when going to the first slide', async () => {
it('should show the prev arrow when going to the first slide', async () => {
await controller.click(nextArrow);
await expect(css(prevArrow, 'opacity')).to.equal('1');
await expect(css(nextArrow, 'opacity')).to.equal('1');
});

// TODO(#40214): fix flaky test.
it.skip('should hide the next arrow when going to the end', async () => {
it('should hide the next arrow when going to the end', async () => {
const el = await getScrollingElement(controller);
await controller.scrollTo(el, {left: (SLIDE_COUNT - 1) * pageWidth});

Expand Down
3 changes: 1 addition & 2 deletions extensions/amp-base-carousel/0.1/test-e2e/test-carousel.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ describes.endtoend(
await expect(slidesRects[0].width).to.equal(pageWidth);
});

// TODO(#24195): fix this flaky test.
it.skip('should layout the two adjacent slides', async function () {
it('should layout the two adjacent slides', async function () {
const [firstSlideRect, secondSlideRect, lastSlideRect] = [
await controller.getElementRect(await getSlide(controller, 0)),
await controller.getElementRect(await getSlide(controller, 1)),
Expand Down

0 comments on commit be8d413

Please sign in to comment.