[bundle-size-chart] Replace ts-node with tsx
#2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
bundle-size-chart-tsx
branch
from
982a5d0 to
52db29b
Compare
danielrozenberg
force-pushed
the
bundle-size-chart-tsx
branch
from
52db29b to
fb6f198
Compare
erwinmombay
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsxrequires less jumping through hoops to make esm-compatible code work, which is something I changed in a recent PR but haven't tried to deploy to prod until today. Looks like the deployment failed because ofts-node+esmincompatibilities, so this PR should fix it.As a tag-along, I changed tsconfig.json to be as forward and as strict as possible, with minor code fixes