Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Polish UI, fix bugs, add GC feature, refactor #240

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Conversation

luca-dot-sh
Copy link
Contributor

@luca-dot-sh luca-dot-sh commented Jan 28, 2025

This PR changes the following:

Functional:

  • Add GC Feature to frontend Frontend: Garbage Collection #241
  • Add Open File Descriptor feature to frontend eBPF: Monitor File Descriptor Usage #210
  • Add init screen
  • Remove intermediate configuration menu as it is mostly unused
  • Select first available component automatically on visualization screen
  • remove labels axis from overlay to save space
  • add labels to overlay launcher
  • improve data mocking Integrate better product simulation #235
  • fix non-working vfs_write visulization
  • enter now closes keyboard on search in processes list
  • remove global option from visulization -> no more crashes
  • add hint on no search results instead of infinite spinner
  • error screen is now displayed directly on startup if backend is not started
  • Make all charts responsive to interval where applicable
  • Add legends when there are two charts
  • Add hint to Overlay if there is no data
  • Add hint to Vislization if there is no data
  • Add missing axes labels to some charts

Refactoring:

  • refactor the mappings from data to chart and event, seperate them in ui.visualization.mappings
  • remove unnecessary DataFlowAggregators layer
  • add preperation for indexing symbols, currently needs to be done after starting daemon via Rust Client CLI

See for video with changes: #237

Closes: #235
Closes: #241

…actor configuration conversion

Signed-off-by: Luca Bretting <[email protected]>
- visualization now displays correct selection and not global
- processes screen now dismisses keyboard on enter and searches
- processes screen no longer shows infinite spinner on search with empty results

Signed-off-by: Luca Bretting <[email protected]>
Signed-off-by: Luca Bretting <[email protected]>
…hw keyboard, fix vfs_write data aggregation and make it responsive to interval, ktfmt

Signed-off-by: Luca Bretting <[email protected]>
 Additionaly:
 - axis labels on overlay screen
 - better aggregation, working intervals on more graphs
 - seperate mappings for event list and chart
 - remove unneeded abstraction layer for data aggregation

Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh luca-dot-sh requested a review from fhilgers January 28, 2025 21:16
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Collaborator

@fhilgers fhilgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhilgers fhilgers merged commit d24ae9a into dev Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants