generated from amosproj/amos202Xss0Y-projname
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Polish UI, fix bugs, add GC feature, refactor #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Bretting <[email protected]>
…actor configuration conversion Signed-off-by: Luca Bretting <[email protected]>
…neccessary Signed-off-by: Luca Bretting <[email protected]>
- visualization now displays correct selection and not global - processes screen now dismisses keyboard on enter and searches - processes screen no longer shows infinite spinner on search with empty results Signed-off-by: Luca Bretting <[email protected]>
… screen Signed-off-by: Luca Bretting <[email protected]>
Signed-off-by: Luca Bretting <[email protected]>
Signed-off-by: Luca Bretting <[email protected]>
…hw keyboard, fix vfs_write data aggregation and make it responsive to interval, ktfmt Signed-off-by: Luca Bretting <[email protected]>
Additionaly: - axis labels on overlay screen - better aggregation, working intervals on more graphs - seperate mappings for event list and chart - remove unneeded abstraction layer for data aggregation Signed-off-by: Luca Bretting <[email protected]>
Signed-off-by: Luca Bretting <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
luca-dot-sh
force-pushed
the
polish_ui_and_add_gc
branch
from
January 28, 2025 21:38
5e6ee89
to
71c1a2d
Compare
frontend/app/src/main/java/de/amosproj3/ziofa/platform/configuration/ConfigurationManager.kt
Fixed
Show fixed
Hide fixed
frontend/app/src/main/java/de/amosproj3/ziofa/ui/processes/ProcessesScreen.kt
Fixed
Show fixed
Hide fixed
...p/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/overlay/OverlayAxisLegend.kt
Fixed
Show fixed
Hide fixed
Signed-off-by: Luca Bretting <[email protected]>
luca-dot-sh
force-pushed
the
polish_ui_and_add_gc
branch
from
January 28, 2025 22:06
71c1a2d
to
ca2e975
Compare
fhilgers
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
Functional:
Refactoring:
See for video with changes: #237
Closes: #235
Closes: #241