Feature/bdc skeleton #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Branching Strategy in README.md
Signed-off-by: Felix Zailskas <[email protected]>
One of the deliverables for Sprint 1 is the planning document in PDF Format.
Feature/team logo
Signed-off-by: Felix Zailskas <[email protected]>
…t-01 Upload planning document PDF
…alifier into feature/documentation-setup
Signed-off-by: Felix Zailskas <[email protected]>
Added technology and Repository tools. Issue: #3.
…ecture Add documentation regarding the software architecture
Signed-off-by: Felix Zailskas <[email protected]>
Fixing the licensing issues created by PRs
added impediments screenshot
Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
…mentation added the documentation for pull requests in file Contribution.md
Fix the logo so that only the correct version (dark / light) gets displayed.
Overview over possible features we want to add to our Base Data Collector (BDC)
The dynamic media source was still not working, but now it should
--------- Signed-off-by: Lucca Baumgärtner <[email protected]>
Fix duplicate logo in README
…lifier into feature/bdc-skeleton
Signed-off-by: Lucca Baumgärtner <[email protected]>
…re/bdc-skeleton # Conflicts: # BDC/data/collected_data.json
luccalb
requested changes
Nov 4, 2023
BDC/src/data_collector.py
Outdated
| # SPDX-License-Identifier: MIT | ||
| # SPDX-FileCopyrightText: 2023 Ruchita Nathani <[email protected]> | ||
| import csv | ||
| import requests |
There was a problem hiding this comment.
Please add requests package to the dependencies in Pipfile. You can do so by running pipenv install requests in bash.
BDC/src/data_collector.py
Outdated
| def get_data_from_csv(): | ||
| """Retrieve information from the CSV file and utilize it in the Google API""" | ||
| data = [] | ||
| with open('../data/given_data.csv', 'r', encoding='utf8') as file: |
There was a problem hiding this comment.
This relative path will result in a FileNotFoundError if it's run from anywhere else than inside /BDC/src/. I suggest using absolute paths:
Suggested change
| with open('../data/given_data.csv', 'r', encoding='utf8') as file: | |
| file_path = os.path.join(os.path.abspath(os.path.dirname(__file__)), '../data/given_data.csv') | |
| with open(file_path, 'r', encoding='utf8') as file: |
BDC/src/data_collector.py
Outdated
| if response.status_code == 200: | ||
| data = response.json() | ||
|
|
||
| with open("../data/collected_data.json", "w") as json_file: |
There was a problem hiding this comment.
Same as above.
Suggested change
| with open("../data/collected_data.json", "w") as json_file: | |
| file_path = os.path.join(os.path.abspath(os.path.dirname(__file__)), '../data/collected_data.json') | |
| with open(file_path, "w") as json_file: |
Signed-off-by: Lucca Baumgärtner <[email protected]>
luccalb
force-pushed
the
feature/bdc-skeleton
branch
from
6e5151a to
635c7dd
Compare
luccalb
force-pushed
the
feature/bdc-skeleton
branch
from
635c7dd to
a92a7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a basic structure for the BDC feature. This structure comprises the following components: