Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/76 finish gradle plugin #93

Merged
merged 12 commits into from
Dec 3, 2023
Merged

Conversation

lheimbs
Copy link
Contributor

@lheimbs lheimbs commented Nov 30, 2023

This simply adds the new gradle plugin and adds the classpath to the targetClasses in pitest when started from the context menu
Feedback will be added in a later PR

@lheimbs lheimbs force-pushed the Feature/76-Finish-Gradle-Plugin branch 6 times, most recently from da7f5d4 to 61a191b Compare December 1, 2023 21:15
@lheimbs lheimbs marked this pull request as ready for review December 1, 2023 21:24
@lheimbs lheimbs force-pushed the Feature/76-Finish-Gradle-Plugin branch from 61a191b to da952f5 Compare December 1, 2023 21:26
Copy link
Contributor

@brianneoberson brianneoberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only confusion is concerning the 2 two licenses on the /gradlew files, other than that it looks good to me and works as expected.

pitmutationmate/gradlew Show resolved Hide resolved
Copy link
Contributor

@brianneoberson brianneoberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@lheimbs lheimbs force-pushed the Feature/76-Finish-Gradle-Plugin branch from 04ad937 to 9c2618b Compare December 3, 2023 10:32
Copy link
Contributor

@brianneoberson brianneoberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for approving before, but I just noticed the licences are missing for these files.

.github/linters/.groovylintrc.json Show resolved Hide resolved
.github/linters/.yaml-lint.yml Show resolved Hide resolved
@lheimbs lheimbs merged commit 8316ee6 into main Dec 3, 2023
7 checks passed
@lheimbs lheimbs deleted the Feature/76-Finish-Gradle-Plugin branch December 3, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants