Feature/182: Add android build type to settings and use pitest created folder (if exists) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lheimbs
requested review from
QW3RAT,
brianneoberson,
nikomall34,
timherzig and
lfogarty98
lheimbs
force-pushed
the
Feature/182-buildtype
branch
from
7d21dd9 to
aa1aac2
Compare
nikomall34
approved these changes
Jan 30, 2024
...ate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/configuration/SettingsEditor.kt
Outdated
Show resolved
Hide resolved
| val path = getReportPath() | ||
| if (buildType != null && Files.exists(Path.of("$path/$buildType"))) { | ||
| return Path.of("$path/$buildType") | ||
| } else if (Files.exists(Path.of("$path/debug"))) { |
There was a problem hiding this comment.
I think you for got to test for release buidtype here right?
There was a problem hiding this comment.
I just kept it as was before. If a build type is set - try that one. Otherwise try debug (what we were doing before by default) and then use no build type
There was a problem hiding this comment.
Ok than I would change the message to
val multilineText = "<html>The Android build type of which you want to use for the pitest results from.<br/>If kept empty, <c>debug</c> is tried if it is an Android project.</html>"
198e6e1 to
d42e577
Compare
buildType is for android projects. verbose is to easily enable verbosity in pitest runs. Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
Co-authored-by: nikomall34 <[email protected]>
Signed-off-by: Lennart Heimbs <[email protected]>
lheimbs
force-pushed
the
Feature/182-buildtype
branch
from
d42e577 to
7545ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes settings not being able to get applied in an easy way
I'm still trying to find a way to get the info automatically but haven't found a good solution yet, so adding the config setting as a backup