Feature/103 error message if companion gradle plugin for mutation mate is missing #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 6, 2023 18:59
Signed-off-by: nikomall34 <[email protected]>
…ntation of ProjectActivity. And I deleted a conflicting kotlin dependency Signed-off-by: nikomall34 <[email protected]>
… after 6 seconds Signed-off-by: nikomall34 <[email protected]>
…build.gradle.kts files Signed-off-by: nikomall34 <[email protected]>
…d in the background after the project was opened Signed-off-by: nikomall34 <[email protected]>
….xml file Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
lheimbs
requested changes
Dec 13, 2023
There was a problem hiding this comment.
It works and on my machine except for plugin definitions that are commented out but that could be handled in a future Issue.
Personally I dont like the invasive error message as a popup that has to be dismissed.
As a plugin this seems too overbearing to me, where a simple notification should've sufficed...
Leave it like this but we should discuss what others would prefer.
The change request is aimed at the smallish review comments.
Plus please remove any unneeded stuff that is not required for the tests from the test gradle build files.
.../src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/plugincheck/PluginCheckerGroovy.kt
Show resolved
Hide resolved
.../src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/plugincheck/PluginCheckerKotlin.kt
Show resolved
Hide resolved
...src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/plugincheck/StartupPluginChecker.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/plugincheck/StartupPluginChecker.kt
Outdated
Show resolved
Hide resolved
...mate/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/services/UdpMessagingServer.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: nikomall34 <[email protected]>
…e-plugin-for-MutationMate-is-missing
Signed-off-by: nikomall34 <[email protected]>
…r-MutationMate-is-missing' of github.com:amosproj/amos2023ws02-pitest-ide-plugin into Feature/103-Error-message-if-companion-Gradle-plugin-for-MutationMate-is-missing
|
@lheimbs about the test files. I kept everything in the build files since the whole file is parsed. So I it is good to see in case there are some sections the parser cannot handle. Or what do you mean with unneeded stuff? |
lheimbs
approved these changes
Dec 13, 2023
nikomall34
deleted the
Feature/103-Error-message-if-companion-Gradle-plugin-for-MutationMate-is-missing
branch
nikomall34
restored the
Feature/103-Error-message-if-companion-Gradle-plugin-for-MutationMate-is-missing
branch
nikomall34
deleted the
Feature/103-Error-message-if-companion-Gradle-plugin-for-MutationMate-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a groovy and a kotlin parsers to parse the build files. When the project is opened the parsers are triggered and check if the pitest and the companion plugin are missing. Right now if a project contains the build.gradle and the build.gradle.kts file two error messages will appear (You have to close the first error messages to see the second one).
IMPORTANT: I changed the intellij version to 2023.1. So in order to test it you should clean the project by deleting the .idea, .gradle and build folders. These folders should be deleted in the plugin project and every project you want to open with the intellij idea that runs in the sandbox.
For testing I could only test the groovy parser because the implementation does not rely on intellij. So for the kotlin parsers I tried to mock the intellij project environment with classes from
com.intellij.testFramework. But this didn't work for me. The Problem is that we are using Junit5 and I couldn't find a workaround.In order to test it and see a message you can take the test build scripts rename them to "build.gradle" or "build.gradle.kts" and open a Project in the Intellij Idea Sandbox instance.