Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/98 connect test report data to result window #130

Merged
merged 9 commits into from
Dec 12, 2023
Merged

Feature/98 connect test report data to result window #130

merged 9 commits into from
Dec 12, 2023

Conversation

lfogarty98
Copy link
Contributor

@lfogarty98 lfogarty98 commented Dec 12, 2023 •
edited
Loading

  • feed relevant results from pitest report to result visualisation window in IDE (for now, just the "Latest Result" tab)
  • since the visualisation is reliant on "coverage" results (e.g. line coverage, mutation coverage etc.) which are not parsed by the XML parser, a placeholder data class CoverageReport in the XML parser is defined. This needs to be refactored once the HTML Parser is merged, perhaps a small ticket for the next sprint (@emuguy1 @Felix-012)
  • workflow: a mock set of results in RunConfigurationAction.kt is used to update the "Latest Result" panel in the correspondingToolWindow instance

@lfogarty98
fix linting
6717d03 
Signed-off-by: Liam Fogarty <[email protected]>
timherzig
timherzig reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@timherzig timherzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket features are implemented and working. Code looks good to me, nothing I would change.

brianneoberson
brianneoberson requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@brianneoberson brianneoberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Most of this will have to be updated when the actual results are available through the HTML Parser I believe. Just have a look at the two small comments I left, then it can be merged imo.

...te/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/MutationTestToolWindowFactory.kt Show resolved Hide resolved
...e/src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/actions/RunConfigurationAction.kt Show resolved Hide resolved
brianneoberson
brianneoberson reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@brianneoberson brianneoberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me.

@lfogarty98 lfogarty98 merged commit 4399d3f into main Dec 12, 2023
12 checks passed
@lheimbs lheimbs deleted the Feature/98-connect-test-report-data-to-result-window branch January 31, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timherzig timherzig timherzig left review comments

@brianneoberson brianneoberson brianneoberson approved these changes

@lheimbs lheimbs Awaiting requested review from lheimbs

@nikomall34 nikomall34 Awaiting requested review from nikomall34

@QW3RAT QW3RAT Awaiting requested review from QW3RAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lfogarty98 @timherzig @brianneoberson @lheimbs @nikomall34 @QW3RAT