Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle subsidiary #245

Merged
merged 5 commits into from
Jun 5, 2021
Merged

Toggle subsidiary #245

merged 5 commits into from
Jun 5, 2021

Conversation

CatoLeanTruetschel
Copy link
Collaborator

No description provided.

@CatoLeanTruetschel CatoLeanTruetschel self-assigned this Jun 3, 2021
@CatoLeanTruetschel CatoLeanTruetschel added this to the Sprint 8 milestone Jun 3, 2021
PianoRollRepresentation
PianoRollRepresentation approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@PianoRollRepresentation PianoRollRepresentation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joluj
joluj approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frontend/src/visualization/filtering/SubsidiaryNodesToggle.tsx
color="primary"
/>
}
label="Show subsidiary"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is subsidary a common graph term? If not the description from the would be really helpful. You could show that for example with a tooltip.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not a common term. The explanation in the UI is tracked by #256

@CatoLeanTruetschel CatoLeanTruetschel merged commit b7f259c into main Jun 5, 2021
@CatoLeanTruetschel CatoLeanTruetschel deleted the refactoring/toggle-subsidiary branch June 5, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PianoRollRepresentation PianoRollRepresentation PianoRollRepresentation approved these changes

@joluj joluj joluj approved these changes

Assignees

@CatoLeanTruetschel CatoLeanTruetschel

Labels
None yet
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
3 participants
@CatoLeanTruetschel @joluj @PianoRollRepresentation