Fixed Issue.

amit-webkul · Jan 6, 2025 · 37a0bf7 · 37a0bf7
1 parent fee658f
commit 37a0bf7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/packages/Webkul/Admin/src/Http/Controllers/Settings/AttributeController.php b/packages/Webkul/Admin/src/Http/Controllers/Settings/AttributeController.php
@@ -189,8 +189,12 @@ public function massDestroy(MassDestroyRequest $massDestroyRequest): JsonRespons
     /**
      * Download image or file
      */
-    public function download(): StreamedResponse
+    public function download()
     {
+        if (! request('path')) {
+            return false;
+        }
+
         return Storage::download(request('path'));
     }
 }
diff --git a/packages/Webkul/Admin/src/Resources/views/components/attributes/view/file.blade.php b/packages/Webkul/Admin/src/Resources/views/components/attributes/view/file.blade.php
@@ -1,6 +1,6 @@
 <x-admin::form.control-group.controls.inline.file
     ::name="'{{ $attribute->code }}'"
-    ::value="'{{ route('admin.settings.attributes.download', ['path' => $value]) }}'"
+    ::value="'{{ $value ? route('admin.settings.attributes.download', ['path' => $value]) : '' }}'"
     rules="required|mimes:jpeg,jpg,png,gif"
     position="left"
     :label="$attribute->name"

diff --git a/...ul/Admin/src/Resources/views/components/form/control-group/controls/inline/file.blade.php b/...ul/Admin/src/Resources/views/components/form/control-group/controls/inline/file.blade.php
@@ -34,11 +34,18 @@ class="flex h-[34px] items-center justify-between rounded border border-transpar
 
                 <a 
                     :href="inputValue" 
+                    v-if="inputValue"
                     target="_blank"
                 >
                     <span class="icon-download pl-[2px] text-2xl font-normal"></span>
                 </a>
 
+                <span
+                    v-else
+                    class="icon-download cursor-pointer pl-[2px] text-2xl font-normal"
+                >
+                </span>
+
                 <template v-if="allowEdit">
                     <i
                         @click="toggle"