Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing EXCLUDE consistency #481

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Fixing EXCLUDE consistency #481

wants to merge 1 commit into from

Conversation

ayrton04
Copy link

@ayrton04 ayrton04 commented Mar 8, 2024

Addresses #477.

@ayrton04
Copy link
Author

ayrton04 commented Mar 8, 2024

Also, should this be PR-ed against any other distribution?

@fujitatomoya
Copy link

@sloretz /assign

sloretz
sloretz requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

LGTM once the --filter/--filters change is undone!

ament_cmake_cpplint/cmake/ament_cpplint.cmake Outdated Show resolved Hide resolved
@sloretz sloretz self-assigned this Mar 29, 2024
@ayrton04 ayrton04 changed the title Fixing EXCLUDE consistency and fixing filtering in cpplint Fixing EXCLUDE consistency Apr 1, 2024
@ayrton04 ayrton04 requested a review from sloretz April 1, 2024 10:29
@ayrton04
Copy link
Author

ayrton04 commented Apr 1, 2024

Fixed, sorry about that.

sloretz
sloretz approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@sloretz
Copy link
Contributor

sloretz commented Apr 1, 2024

CI (repos file build: --packages-above-and-dependencies ament_cmake_cpplint ament_cmake_flake8 test: --packages-above ament_cmake_cpplint ament_cmake_flake8)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrton04 @fujitatomoya @sloretz