-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture all Cobra results #14
base: master
Are you sure you want to change the base?
Conversation
|
||
input_filename = ruleset_to_filename[args.ruleset] | ||
|
||
# Remove old input_filename, if it exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this, but it's needed in Cobra's current implementation. Cobra dumps a _Autosar_.txt
file in spaceros_ws/src/<pkg>/
directory. Is it worth asking Cobra maintainers to update this to optionally take an extra command-line parameter, so this file can instead be put in a better location (say, somewhere in spaceros_ws/build/<pkg>/test_results/
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's a good idea. They've been pretty responsive so far. We could also just add the option to Cobra and submit a PR to their repo.
Signed-off-by: Eli Benevedes <[email protected]>
|
||
input_filename = ruleset_to_filename[args.ruleset] | ||
|
||
# Remove old input_filename, if it exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's a good idea. They've been pretty responsive so far. We could also just add the option to Cobra and submit a PR to their repo.
This PR was approved but never merged. I see that there was an intention to change something in Cobra. Did it ever happen? If so, can this be merged or are further changes needed? |
When Cobra is run, it generates an
_Autosar_.txt
file in thespaceros_ws/src/<pkg>/
directory, for the package its currently testing. Inament_cobra/main.py
, we invoke Cobra multiple times. However, each time Cobra is run, it overwrites this_Autosar_.txt
file. These commits accomplish a few things:ament_cobra/main.py
There are a few things that still need to be included in this PR:
However, the present changes are (I hope) the most significant ones, and I think they're ready for review.
@mjeronimo