Implement remaining 'denotes' expectations for conformance test runner #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
commented
Nov 19, 2024
| @@ -59,7 +60,7 @@ private fun IonReader.walk(): List<String> { | |||
| while (true) { | |||
| next() | |||
| val currentType = type | |||
| if (type == null) { | |||
| if (currentType == null) { | |||
There was a problem hiding this comment.
🗺️ This is a minor drive-by improvement that stops the IDE from complaining later on that currentType could be null.
| @@ -141,20 +142,20 @@ private fun TestCaseSupport.denotesModelContent(modelContent: AnyElement, reader | |||
| assertEquals(IonType.STRING, reader.type, failureContext) | |||
| assertEquals(modelContent.stringValue, reader.stringValue(), failureContext) | |||
| } | |||
| is SexpElement -> when (modelContent.head) { | |||
| is SeqElement -> when (modelContent.head) { | |||
There was a problem hiding this comment.
🗺️ Switch to SeqElement ensures that the denotes clause works even if the test is written in JSON instead of Ion. That might not be very relevant in ion-java, but it was an easy change to get some more completeness.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ion-11-encoding #999 +/- ##
==================================================
Coverage ? 70.59%
Complexity ? 7095
==================================================
Files ? 203
Lines ? 28242
Branches ? 5037
==================================================
Hits ? 19937
Misses ? 6717
Partials ? 1588 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Co-authored-by: Tyler Gregg <[email protected]>
tgregg
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None.
Description of changes:
Implements
denotesfor float, decimal, timestamp, and for structs that don't have duplicate field names.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.