Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conformance test runner #997

Merged

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

  • Updates the conformance test runner to support both bytes and binary for binary fragments. This is a temporary change until Resolve 'bytes'/'binary' discrepancy ion-tests#129 is merged and ion-java is updated to have the latest commit of ion-tests.
  • Refactors ConformanceTestRunner into an abstract class. We can create one subclass for each reader configuration. This makes it easier to run a subset of tests (which is faster than running all of them) or to focus on a specific reader implementation. We can also have separate skip lists for the different readers if we so choose. It also means that the test report uses the reader configuration as the top level grouping rather than the very lowest level differentiator.
  • Updated the test names so that the source file is at the start of every name. E.g. [system_macros/default.ion] the first argument can be a single value

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from tgregg November 15, 2024 17:07
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (ion-11-encoding@7cd94d4). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #997   +/-   ##
==================================================
  Coverage                   ?   70.57%           
  Complexity                 ?     7085           
==================================================
  Files                      ?      201           
  Lines                      ?    28215           
  Branches                   ?     5034           
==================================================
  Hits                       ?    19912           
  Misses                     ?     6716           
  Partials                   ?     1587           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt merged commit 411c339 into amazon-ion:ion-11-encoding Nov 15, 2024
17 of 36 checks passed
@popematt popematt deleted the conformance-test-improvements branch November 15, 2024 22:05
tgregg pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants