Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
bytes
andbinary
for binary fragments. This is a temporary change until Resolve 'bytes'/'binary' discrepancy ion-tests#129 is merged andion-java
is updated to have the latest commit ofion-tests
.ConformanceTestRunner
into an abstract class. We can create one subclass for each reader configuration. This makes it easier to run a subset of tests (which is faster than running all of them) or to focus on a specific reader implementation. We can also have separate skip lists for the different readers if we so choose. It also means that the test report uses the reader configuration as the top level grouping rather than the very lowest level differentiator.[system_macros/default.ion] the first argument can be a single value
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.