Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename compact_* parameter encodings to flex_* #992

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jobarr-amzn
Copy link
Contributor

Description of changes:
Names like compact_int are out of date; the spec now says e.g. flex_int. See E-expressions#Tagless Encodings

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jobarr-amzn jobarr-amzn requested a review from zslayton November 13, 2024 18:23
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (ion-11-encoding@d434d2a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/main/java/com/amazon/ion/impl/macro/Macro.kt 50.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #992   +/-   ##
==================================================
  Coverage                   ?   70.56%           
  Complexity                 ?     7085           
==================================================
  Files                      ?      201           
  Lines                      ?    28215           
  Branches                   ?     5034           
==================================================
  Hits                       ?    19911           
  Misses                     ?     6717           
  Partials                   ?     1587           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jobarr-amzn jobarr-amzn merged commit 7cd94d4 into amazon-ion:ion-11-encoding Nov 13, 2024
20 of 36 checks passed
@jobarr-amzn jobarr-amzn deleted the compact-flex branch November 13, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants