Adds BufferedAppendableFastAppendable #845
Merged
+123
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
force-pushed
the
buffered-appendable
branch
from
06f14bd to
b1cc314
Compare
tgregg
approved these changes
May 10, 2024
tgregg
pushed a commit
that referenced
this pull request
Jun 28, 2024
tgregg
pushed a commit
that referenced
this pull request
Sep 9, 2024
tgregg
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
_Private_FastAppendablewrapper forAppendablethat buffers untilflush()is called.Ion11Testto ensure that it handles encoding directives properly.BlockedBufferingOutputStreamFastAppendableto justBufferedOutputStreamFastAppendableand updated itsflush()andclose()behavior to be consistent withOutputStreamFastAppendable.I know I've got another import change in this diff. I'm working separately to eliminate those.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.