-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change IonSystemBuilder
's default charset to UTF-8
#802
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
============================================
+ Coverage 67.23% 67.41% +0.17%
- Complexity 5484 5518 +34
============================================
Files 159 160 +1
Lines 23025 23077 +52
Branches 4126 4126
============================================
+ Hits 15481 15557 +76
+ Misses 6262 6246 -16
+ Partials 1282 1274 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve as long as a dry run looks good
Issue #, if available:
Fix #783
Description of changes:
IonSystemBuilder
toUTF-8
IonSystem
does interact with the catalog outside of the reader/writer builders throughcreateSharedSymbolTable()
. I don't think there's a good way to define how that method should interact with multiple catalogs since a shared symbol table could be present in one catalog but not in another.IonSystemLite
are all non-functional. I cleaned up some formatting near the reader/wwriter builder member fields (and updated the copyright header).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.