Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro parameter cardinality and minor todos #798

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

This updates the MacroCompiler to take care of a few "todo" items, support all the *, +, !, and ? cardinality sigils, and remove the [] grouping syntax.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@popematt popematt requested a review from tgregg April 19, 2024 17:47
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (ion-11-encoding@4cd5c75). Click here to learn what that means.

Files Patch % Lines
src/main/java/com/amazon/ion/impl/macro/Macro.kt 61.53% 1 Missing and 4 partials ⚠️
...in/java/com/amazon/ion/impl/macro/MacroCompiler.kt 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #798   +/-   ##
==================================================
  Coverage                   ?   68.43%           
  Complexity                 ?     6040           
==================================================
  Files                      ?      171           
  Lines                      ?    24578           
  Branches                   ?     4426           
==================================================
  Hits                       ?    16820           
  Misses                     ?     6422           
  Partials                   ?     1336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt merged commit 91493a1 into amazon-ion:ion-11-encoding Apr 19, 2024
7 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants