Makes AbstractIonWriter.writeValues iterative. #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Apr 12, 2024
| @@ -87,90 +87,124 @@ public final void writeValue(final IonReader reader) throws IOException | |||
|
|
|||
| public final void writeValueRecursive(final IonReader reader) throws IOException | |||
There was a problem hiding this comment.
Perhaps it would be good to add a comment saying that it does a depth-first (recursion-like) traversal of the all values on the IonReader, but the method is not actually implemented using recursion.
tgregg
force-pushed
the
abstractionwriter-writevalues-iterative
branch
from
209398b to
5367d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Employs the exact same technique from #368. The code is almost identical in both places; this PR does not aim to address the existing issue of duplication, which would require some refactoring. The fix from #368 affects the text writer, while this PR affects the binary writer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.