Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds recommendation to use IonElement #772

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

Recommends using IonElement instead of IonValue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also put this note in the JavaDoc overview for IonValue?

@popematt
Copy link
Contributor Author

Should we also put this note in the JavaDoc overview for IonValue?

Yes, i can do that.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (3c1b6b1) to head (709cf24).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
+ Coverage     67.23%   67.28%   +0.05%     
- Complexity     5484     5491       +7     
============================================
  Files           159      159              
  Lines         23025    23026       +1     
  Branches       4126     4124       -2     
============================================
+ Hits          15481    15494      +13     
+ Misses         6262     6256       -6     
+ Partials       1282     1276       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@popematt popematt merged commit 23a9346 into amazon-ion:master Mar 14, 2024
22 of 35 checks passed
@popematt popematt deleted the ion-element branch March 14, 2024 19:29
tgregg pushed a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants