Adds support for reading binary Ion 1.1 delimited containers. #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Apr 15, 2024
Comment on lines
+1671
to
+1672
| // Pin the current buffer offset so that all bytes encountered while finding the end of the delimited container | ||
| // are buffered. |
There was a problem hiding this comment.
Is it a requirement to be able to pre-fill a delimited container? That seems somewhat antithetical to the use cases that delimited containers are intended to support.
There was a problem hiding this comment.
It's a requirement in order to comply with the following APIs/contracts:
- IonCursor's
fillValue, which allows the user to fill any value at any depth (note: there is no proposed API to expose to the user whether or not a container is delimited, so it is not reasonable to restrict usage of this API to length-prefixed containers) - The reader's "incremental" mode, which uses
fillValueunder the hood to ensure the next top-level value is buffered before returning a non-null type fromIonReader.next().
When incremental mode is not enabled (which is the common case), and when IonCursor.fillValue is not used directly (there are no direct users yet), delimited containers will not be pre-filled.
popematt
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Any suggestions for simplification are appreciated. No performance testing has yet been done.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.