Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets binary reader buffers to null on close(). #694

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

tgregg
Copy link
Contributor

@tgregg tgregg commented Jan 10, 2024

Issue #, if available:
Closes #678

Description of changes:
This allows these objects to be garbage collected even if the user holds onto the IonReader reference after calling close().

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebf8f4d) 67.25% compared to head (5fbecf6) 67.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #694      +/-   ##
============================================
- Coverage     67.25%   67.24%   -0.01%     
+ Complexity     5486     5482       -4     
============================================
  Files           159      159              
  Lines         23016    23019       +3     
  Branches       4124     4124              
============================================
  Hits          15479    15479              
- Misses         6255     6256       +1     
- Partials       1282     1284       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bousselham-mhidi
Copy link

Do you know when this PR will be merged please ?

@tgregg tgregg merged commit 2ae8b74 into master Jan 16, 2024
10 of 35 checks passed
@tgregg tgregg deleted the null-on-close branch January 16, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop references to internal buffer in IonCursorBinary.close
4 participants