Ensures the binary IonReader throws when a value method that returns a primitive type is invoked on a null value. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #693 +/- ##
============================================
- Coverage 67.25% 67.24% -0.02%
- Complexity 5485 5487 +2
============================================
Files 159 159
Lines 23019 23027 +8
Branches 4124 4128 +4
============================================
+ Hits 15482 15485 +3
- Misses 6255 6259 +4
- Partials 1282 1283 +1 ☔ View full report in Codecov by Sentry. |
jobarr-amzn
reviewed
Jan 10, 2024
Comment on lines
395
to
412
|
|
||
| @Test | ||
| public void expectAttemptToParseNullScalarAsJavaPrimitiveToFailCleanly() { | ||
| IonReaderContinuableCoreBinary reader = initializeReader( | ||
| true, | ||
| 0xE0, 0x01, 0x00, 0xEA, | ||
| 0x0F, // null.null | ||
| 0x1F, // null.bool | ||
| 0x2F, // null.int | ||
| 0x3F, // null.int | ||
| 0x4F, // null.float | ||
| 0x5F // null.decimal | ||
| ); |
There was a problem hiding this comment.
This test should be broken up into multiple tests
…a primitive type is invoked on a null value.
jobarr-amzn
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#684 (note: this should also be done for the text reader)
Description of changes:
The pre-1.11.0 binary reader would allow this in some cases, returning some form of
0rather than throwing. If that behavior is desirable in certain applications, those applications should useIonReader.isNullValue()to check nullness and decide whether using a zero value in that case makes sense.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.