Adds data model for Macros #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft because there's some style violations I need to sort out in the copy/pasted code. |
popematt
force-pushed
the
macro_model
branch
from
b950171 to
0ca83ab
Compare
popematt
force-pushed
the
macro_model
branch
from
0ca83ab to
b371fae
Compare
tgregg
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
IonElementinto this repo. This is a stopgap solution so that we don't have to use IonValue for template body expressions. Don't bother reviewing the content of this commit because it is just a copy/paste, but feel free to comment on whether you think the copy/paste is a good/bad idea if you have an opinion on the matter.Macro,TemplateMacro,MacroRef,MacroSignature,TemplateExpression, and more. This model is intended to be used for reading, writing, and evaluating macros.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.