Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates write support for binary Ion 1.1 decimals and timestamps #644

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

amazon-ion/ion-docs#286

Description of changes:

Updates encoding implementation and tests according to amazon-ion/ion-docs#286

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (ion-11-encoding@baa2d61). Click here to learn what that means.

❗ Current head 69a28ff differs from pull request most recent head 1a41e8a. Consider uploading reports for the commit 1a41e8a to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             ion-11-encoding     #644   +/-   ##
==================================================
  Coverage                   ?   67.04%           
  Complexity                 ?     5462           
==================================================
  Files                      ?      159           
  Lines                      ?    22994           
  Branches                   ?     4119           
==================================================
  Hits                       ?    15416           
  Misses                     ?     6299           
  Partials                   ?     1279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/com/amazon/ion/impl/bin/IonEncoder_1_1.java Outdated Show resolved Hide resolved
@popematt popematt changed the base branch from master to ion-11-encoding November 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants