Ensures that the binary reader can handle a ByteArrayInputStream that returns a negative number from available(). #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Oct 25, 2023
… bytes than requested before reaching EOF.
tgregg
force-pushed
the
handle-throttled-inputstream
branch
from
cf6ef90 to
72c1962
Compare
… returns a negative number from available().
tgregg
force-pushed
the
handle-throttled-inputstream
branch
from
72c1962 to
884ae15
Compare
…ely classifying all 4-byte ints as Java longs.
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Surprisingly,
ByteArrayInputStream.available()can return a negative number. This causes problems when the cursor tries to select a fixed-size buffer configuration. This PR fixes the problem by ensuring that the size 0 configuration is used in this case.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.