Makes the binary reader set the encoding version when seeked to a span. #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
popematt
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
SpanProviderandSeekableReaderfacets allow users to retrieveSpanobjects that point to the value at which a reader is currently positioned, and later seek a reader to that position.Usually, users seek back to spans previously created by the same reader. However, sometimes users will create a span using one reader and then try to seek a different reader to that span. This works as long as both readers point at the same data. Existing tests only tested seeking to spans created by the same reader.
Before this change, if the reader receiving the span to seek to had not yet read any data (i.e., had not yet encountered an IVM), it would be in a state where it considered all type ID bytes invalid. This change fixes that by determining the span's Ion encoding version from its associated symbol table and setting the reader's state accordingly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.